Skip to content

fix(dav): add repair step to queue job to update rooms and resources #52708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

fix(dav): add repair step to queue job to update rooms and resources #52708

merged 1 commit into from
May 16, 2025

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented May 9, 2025 •
edited
Loading

Summary

Add a repair step to re-queue the job to update rooms and resources in case it gets lost.

Checklist

@st3iny
fix(dav): add repair step to queue job to update rooms and resources
cef60f9 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny self-assigned this May 9, 2025
@st3iny st3iny requested a review from a team as a code owner May 9, 2025 15:22
@st3iny st3iny removed the request for review from a team May 9, 2025 15:22
@st3iny st3iny added the bug label May 9, 2025
@st3iny st3iny added 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals labels May 9, 2025
@st3iny
Copy link
Member Author

st3iny commented May 9, 2025

/backport to stable30

@st3iny
Copy link
Member Author

st3iny commented May 9, 2025

/backport to stable31

@st3iny
Copy link
Member Author

st3iny commented May 12, 2025

/backport to stable29

@st3iny st3iny requested a review from ChristophWurst May 12, 2025 08:05
ChristophWurst
ChristophWurst reviewed May 12, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the info.xml entries take care of this already.

<job>OCA\DAV\BackgroundJob\UpdateCalendarResourcesRoomsBackgroundJob</job>

If not, could this be a server problem worth generalizing? As in, requeue any info.xml-registered job if it no longer exists.

ChristophWurst
ChristophWurst approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval despite #52708 (review) because this is acceptable as a quickfix

In general this should be done for any of these jobs

@st3iny
Copy link
Member Author

st3iny commented May 16, 2025

I thought the info.xml entries take care of this already.

<job>OCA\DAV\BackgroundJob\UpdateCalendarResourcesRoomsBackgroundJob</job>

If not, could this be a server problem worth generalizing? As in, requeue any info.xml-registered job if it no longer exists.

I agree. I'll add this to my list to investigate.

@st3iny st3iny merged commit 3699eed into master May 16, 2025
206 of 217 checks passed
@st3iny st3iny deleted the fix/dav/update-rooms-resources-background-job branch May 16, 2025 10:39
@st3iny st3iny added this to the Nextcloud 32 milestone May 16, 2025
This was referenced May 16, 2025
Merged
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

Assignees

@st3iny st3iny

Labels

3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals feature: dav

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Add repair job to insert background job to update rooms and resources

5 participants

@st3iny @ChristophWurst @SebastianKrupinski @skjnldsv