fix(webhooks_listener): correctly set userId from event #52699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
requested review from
Altahrim and
sorbaugh
and removed request for
a team
|
/backport to stable30 |
kyteinsky
reviewed
May 9, 2025
kyteinsky
approved these changes
May 9, 2025
|
/backport to stable31 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
$appApiFunctions->exAppRequestwe should pass the userID from which the event occurred, not the userID that registered the webhook.This was a typo in the original code.
This only affects AppAPI and ExApps, but we should backport this fix to Nextcloud 30/31.
Checklist