Skip to content

N?A #52692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

N?A #52692

wants to merge 6 commits into from

Conversation

@AndyXheli
Copy link
Contributor

@AndyXheli AndyXheli commented May 8, 2025 •
edited
Loading

No description provided.

@AndyXheli
Update Logging for preview generation
74db743 
Since this PR was implemented, the log file has been flooded with warnings stating, "Cached preview not found for file; generating a new preview." This appears to be more of an informational message rather than a warning. This PR will change it from warning to info 

Original PR
nextcloud#52300

Signed-off-by: AndyXheli <andyxheli@gmail.com>
@AndyXheli AndyXheli requested a review from a team as a code owner May 8, 2025 14:38
@AndyXheli AndyXheli requested review from Altahrim, ArtificialOwl and sorbaugh and removed request for a team May 8, 2025 14:38
@AndyXheli AndyXheli mentioned this pull request May 13, 2025
Closed
8 tasks
@joshtrichards joshtrichards linked an issue May 13, 2025 that may be closed by this pull request
[Bug]: Spamming Logs Cached preview not found for file generating a new preview. #52791
Closed
8 tasks
@joshtrichards joshtrichards requested review from artonge and nfebe May 13, 2025 14:15
@joshtrichards joshtrichards added this to the Nextcloud 32 milestone May 13, 2025
@joshtrichards
Copy link
Member

/backport to stable31

joshtrichards
joshtrichards approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info works; debug probably fine here even

@AndyXheli
Copy link
Contributor Author

info works; debug probably fine here even

I can update it to debug i think that would be better

@joshtrichards
Copy link
Member

@AndyXheli - Can you fix the commit message to make it in conventional format? i.e.

fix(previews): lower log level when cached preview isn't found

@AndyXheli AndyXheli changed the title Update Logging for preview generation fix(previews): lower log level when cached preview isn't found May 14, 2025
@AndyXheli
fix(previews): lower log level when cached preview isn't found
ae25e8f 
fix(previews): lower log level when cached preview isn't found

Signed-off-by: AndyXheli <andyxheli@gmail.com>
@AndyXheli
Copy link
Contributor Author

@AndyXheli - Can you fix the commit message to make it in conventional format? i.e.

fix(previews): lower log level when cached preview isn't found

Should be all good now ;)

@artonge
Copy link
Contributor

artonge commented May 15, 2025

Should be all good now ;)

You still have unconventional commit message.
Also, can you remove the merge commit?
https://github.com/nextcloud/server/pull/52692/commits

@AndyXheli
Revert "Merge branch 'master' into patch-1"
9ebe4db 
This reverts commit 4bd92a4, reversing
changes made to ae25e8f.
@AndyXheli AndyXheli closed this May 15, 2025
@AndyXheli AndyXheli changed the title fix(previews): lower log level when cached preview isn't found N?A May 15, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@AndyXheli AndyXheli deleted the patch-1 branch May 23, 2025 02:22
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtrichards joshtrichards joshtrichards approved these changes

@artonge artonge artonge approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

@st3iny st3iny Awaiting requested review from st3iny

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 is a code owner

Assignees

No one assigned

Labels

3. to review Waiting for reviews backport-request bug feature: logging feature: previews and thumbnails feedback-requested

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

[Bug]: Spamming Logs Cached preview not found for file generating a new preview.

4 participants

@AndyXheli @joshtrichards @artonge @skjnldsv