Skip to content

ConfigLexicon to update lazy status #52671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ConfigLexicon to update lazy status #52671

wants to merge 3 commits into from
+136 −1

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented May 6, 2025 •
edited
Loading

Migrate a previously existing config value to right lazyness when set as lazy in Lexicon.

  • tests

@ArtificialOwl ArtificialOwl requested a review from a team as a code owner May 6, 2025 23:29
@ArtificialOwl ArtificialOwl requested review from artonge, nfebe and skjnldsv and removed request for a team May 6, 2025 23:29
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label May 6, 2025
@ArtificialOwl ArtificialOwl added this to the Nextcloud 32 milestone May 6, 2025
@ArtificialOwl ArtificialOwl changed the title feat(appconfig): lexicon update lazy status ConfigLexicon to update lazy status May 7, 2025
@ArtificialOwl ArtificialOwl added the 2. developing Work in progress label May 7, 2025
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/lexicon-update-lazy-status branch from 55cb1ee to 7f763fa Compare May 7, 2025 00:32
@ArtificialOwl
feat(appconfig+userconfig): lexicon update lazy status
62a82ae 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/lexicon-update-lazy-status branch from 7f763fa to 62a82ae Compare May 7, 2025 15:08
@ArtificialOwl ArtificialOwl removed the 2. developing Work in progress label May 7, 2025
@skjnldsv
Merge branch 'master' into fix/noid/lexicon-update-lazy-status
7fa69d2 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
skjnldsv reviewed Aug 1, 2025
View reviewed changes
@skjnldsv
fix: unwanted imports after rebase
910a0d3 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the fix/noid/lexicon-update-lazy-status branch from e8d10cf to 910a0d3 Compare August 1, 2025 11:21
@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2025

Tried to rebase and fix tiny issues to help this move forward, but it's having some more issues it seems :)

1) Tests\lib\Config\LexiconTest::testAppConfigMigrationToLazy
TypeError: OC\AppFramework\Bootstrap\RegistrationContext::getConfigLexicon(): Return value must be of type ?OCP\Config\Lexicon\ILexicon, Tests\lib\Config\TestConfigLexicon_Migration returned

/home/runner/actions-runner/_work/server/server/lib/private/AppFramework/Bootstrap/RegistrationContext.php:1032

This was referenced Aug 22, 2025
Merged
Merged
Merged
This was referenced Sep 2, 2025
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 10, 2025
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 18, 2025
Merged
This was referenced Sep 25, 2025
Merged
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@ArtificialOwl @skjnldsv @artonge