Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Apr 30, 2025

Needed for Photos' sidebar tab
Regression introduced by #50109

@artonge artonge requested review from a team and skjnldsv as code owners April 30, 2025 15:18
@artonge artonge requested review from susnux and szaimen and removed request for a team April 30, 2025 15:18
@artonge artonge self-assigned this Apr 30, 2025
@artonge artonge added bug 3. to review Waiting for reviews javascript feature: file sidebar Related to the file sidebar component labels Apr 30, 2025
@artonge artonge added this to the Nextcloud 32 milestone Apr 30, 2025
@artonge
Copy link
Contributor Author

artonge commented Apr 30, 2025

/backport to stable31

@artonge
Copy link
Contributor Author

artonge commented Apr 30, 2025

/compile amend /

Needed for Photos' sidebar tab

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the artonge/fix/attribute_in_sidebar branch from 970ed9e to eab2d9e Compare April 30, 2025 15:27
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux
Copy link
Contributor

susnux commented Apr 30, 2025

(We really need to implement Nextcloud Node API based sidebar instead of legacy fileinfo API)

@susnux susnux merged commit 2036bee into master Apr 30, 2025
132 of 134 checks passed
@susnux susnux deleted the artonge/fix/attribute_in_sidebar branch April 30, 2025 16:07
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: file sidebar Related to the file sidebar component javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants