fix(share): assume download enabled on federated share #52543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
requested review from
Altahrim,
artonge and
provokateurin
and removed request for
a team
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/52060/manage-download-on-federated-reshare
branch
from
f9f07d7 to
cc96782
Compare
|
/backport to stable31 |
yemkareems
approved these changes
May 8, 2025
|
@ArtificialOwl I think Nextcloud 30 is affected by the same issue (at least the symptoms are identical). Any plans to backport to version 30 as well? |
|
/backport to stable30 |
Merged
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #52060
The logic behind this condition is that if the file originate from a remote instance (federated share), then we can assume that the file is set as downloadable. We only know that for sure when trying to access the remote document.
Meaning that if you reshare it, you can assume that the document is downloadable and enable the checkbox on the share interface. Then the $hideDownload kicks in and disable the download to the final recipient, in case download permission is not kept on the reshare