Skip to content

fix(dav): check the owner displayName scope before giving attribute #52535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

fix(dav): check the owner displayName scope before giving attribute #52535

merged 2 commits into from
Apr 30, 2025

Conversation

@skjnldsv
Copy link
Member

Caught after #45652

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Apr 29, 2025
@skjnldsv skjnldsv self-assigned this Apr 29, 2025
@skjnldsv skjnldsv requested review from a team as code owners April 29, 2025 14:43
@skjnldsv skjnldsv requested review from come-nc, nfebe, susnux, szaimen and yemkareems and removed request for a team April 29, 2025 14:43
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 29, 2025 •
edited
Loading

/backport 58aadde to stable31

@skjnldsv skjnldsv force-pushed the fix/public-owner-scope branch from f8b4f37 to bdad86c Compare April 29, 2025 14:44
come-nc
come-nc approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me apart from typos between usermanager and accountmanager

@szaimen szaimen removed their request for review April 29, 2025 15:00
@skjnldsv skjnldsv force-pushed the fix/public-owner-scope branch 3 times, most recently from 03c10b6 to e80194a Compare April 30, 2025 06:30
@skjnldsv
Copy link
Member Author

Added tests

@skjnldsv
fix(dav): check the owner displayName scope before giving attribute
58aadde 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/public-owner-scope branch from e80194a to 58aadde Compare April 30, 2025 06:37
@skjnldsv
Copy link
Member Author

/compile

@nextcloud-command
chore(assets): Recompile assets
b95695b 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
Copy link
Member Author

/backport 58aadde to stable30

@skjnldsv skjnldsv merged commit c06d851 into master Apr 30, 2025
191 checks passed
@skjnldsv skjnldsv deleted the fix/public-owner-scope branch April 30, 2025 06:59
This was referenced Apr 30, 2025
Merged
Merged
@ArtificialOwl ArtificialOwl mentioned this pull request Jun 25, 2025
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@come-nc come-nc come-nc approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug feature: dav feature: sharing regression

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @susnux @come-nc @nextcloud-command