fix(files_sharing): Filter own shares that are reshares #52503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
Altahrim,
skjnldsv and
yemkareems
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
susnux
approved these changes
May 6, 2025
|
(tests would be nice to test the difference between before and after) |
come-nc
reviewed
May 6, 2025
provokateurin
force-pushed
the
fix/files_sharing/filter-own-reshared-shares
branch
from
2b402dc to
9269a8b
Compare
yemkareems
approved these changes
May 6, 2025
come-nc
approved these changes
May 6, 2025
|
The same tests fails three times in a row:
Not sure whether related, but could be. |
|
It's related, I'm working on it. |
skjnldsv
approved these changes
May 7, 2025
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/files_sharing/filter-own-reshared-shares
branch
from
9269a8b to
7c6602c
Compare
This was referenced May 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Shares were only filtered if the current user is the owner, but in a reshare they are not the owner.
Checklist