Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Apr 28, 2025

Backport of #52423

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from kesselb, nfebe and skjnldsv April 28, 2025 10:02
@backportbot backportbot bot added 3. to review Waiting for reviews feature: sharing labels Apr 28, 2025
@backportbot backportbot bot added this to the Nextcloud 31.0.5 milestone Apr 28, 2025
@nfebe nfebe marked this pull request as ready for review April 28, 2025 10:05
@nfebe nfebe enabled auto-merge April 28, 2025 10:05
@nfebe
Copy link
Contributor

nfebe commented Apr 28, 2025

/compile amend

@nfebe nfebe disabled auto-merge April 28, 2025 10:07
@nextcloud-command nextcloud-command force-pushed the backport/52423/stable31 branch from 90d6036 to f8c65d7 Compare April 28, 2025 10:09
@maximelehericy
Copy link

as discussed with @nfebe, please hold this backport until discussion about customers impact have happened 🙏

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a config flag to switch the behavior to have this in "internal" shares

@blizzz blizzz mentioned this pull request May 5, 2025
10 tasks
Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the backport/52423/stable31 branch from f8c65d7 to 5788dfa Compare May 6, 2025 14:33
@nfebe
Copy link
Contributor

nfebe commented May 6, 2025

/compile

nfebe and others added 3 commits May 6, 2025 15:37
Replaced multiple Array.filter() calls with a single loop to improve performance.

This avoids redundant iterations over the shares array and categorizes them more efficiently.

Signed-off-by: nfebe <fenn25.fn@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@nfebe nfebe force-pushed the backport/52423/stable31 branch from 5788dfa to 6873632 Compare May 6, 2025 14:37
@nfebe
Copy link
Contributor

nfebe commented May 6, 2025

Included : #52511

@nfebe nfebe enabled auto-merge May 6, 2025 14:38
@nfebe nfebe requested a review from AndyScherzinger May 6, 2025 14:38
@nfebe
Copy link
Contributor

nfebe commented May 6, 2025

/compile

nfebe and others added 2 commits May 6, 2025 15:53
…g input

- Fix autoloading for new `ConfigLexicon`
- Ensure that sharing input in sharing tab respect `show-federated-shares-as-internal`:
This is important, because when federated shares are shown as internal the users should add them from the internal shares section

Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe force-pushed the backport/52423/stable31 branch from e07c389 to d616a73 Compare May 6, 2025 14:54
@nfebe nfebe merged commit 36cd949 into stable31 May 6, 2025
197 of 207 checks passed
@nfebe nfebe deleted the backport/52423/stable31 branch May 6, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants