fix(files): middle click & ctrl new tab #52438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
artonge,
sorbaugh and
susnux
and removed request for
a team
|
/backport to stable31 |
susnux
reviewed
Apr 27, 2025
| // if ctrl+click / cmd+click (MacOS uses the meta key) or middle mouse button (button & 4), open in new tab | ||
| // also if there is no default action use this as a fallback | ||
| const metaKeyPressed = event.ctrlKey || event.metaKey || Boolean(event.button & 4) | ||
| const metaKeyPressed = event.ctrlKey || event.metaKey || event.button === 1 |
There was a problem hiding this comment.
I see it should have been Boolean(event.buttons & 4) (missing s).
So its an binary mask for bit 4 which means mouse wheel.
But then also the condition in line 330 is wrong.
There was a problem hiding this comment.
Does that mean line 348 is also wrong ?
susnux
approved these changes
Apr 27, 2025
artonge
approved these changes
Apr 28, 2025
|
Any way we can add a test for this? I feel this broke quite a few times in the past already |
At least not checking new tab is opened with Cypress. Does not work by design and would need a different test runner like playwright |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #52380
Regression from #45652