refactor: Thumbnail Generator logging and tests #52299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
added
3. to review
|
The refactored tests seem a bit unrelated? At least there are no actual changes to the tests afaict. |
Yes, it just a refactor, as I opened those files but the time I could amend the commit the failing jobs passed for the main changes so moved this to a new PR |
come-nc
approved these changes
Apr 22, 2025
provokateurin
approved these changes
Apr 22, 2025
susnux
reviewed
Apr 22, 2025
nfebe
force-pushed
the
refactor/preview-tests
branch
from
cf54e33 to
fd26baf
Compare
susnux
reviewed
Apr 23, 2025
nfebe
force-pushed
the
refactor/preview-tests
branch
2 times, most recently
from
a985e2b to
122cd46
Compare
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
refactor/preview-tests
branch
from
122cd46 to
d980e69
Compare
|
/backport to stable31 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor follow up for : #52221