Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

Summary

  • Modified card object move logic to modify object uri during dav operation

Checklist

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable31

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable30

@SebastianKrupinski SebastianKrupinski force-pushed the fix/issue-50748-card-object-move branch from f8cae0f to b883d54 Compare April 21, 2025 21:39
@SebastianKrupinski SebastianKrupinski changed the title fix: do not ignore move command object target uri fix(CardDAV): do not ignore move command object target uri Apr 22, 2025
@SebastianKrupinski SebastianKrupinski force-pushed the fix/issue-50748-card-object-move branch from b883d54 to 06909f3 Compare April 30, 2025 18:52
@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2025

@SebastianKrupinski is it still needed, linked issue is closed

@SebastianKrupinski
Copy link
Contributor Author

Hey @skjnldsv

The original ticket was for CalDAV but CardDAV was also broken so this is the fix for CardDAV

@SebastianKrupinski SebastianKrupinski force-pushed the fix/issue-50748-card-object-move branch from 06909f3 to df04f28 Compare August 1, 2025 13:27
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the fix/issue-50748-card-object-move branch from df04f28 to 49d8e29 Compare August 1, 2025 13:36
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 1, 2025
@skjnldsv skjnldsv merged commit 17ae4e7 into master Aug 1, 2025
226 of 239 checks passed
@skjnldsv skjnldsv deleted the fix/issue-50748-card-object-move branch August 1, 2025 15:07
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Aug 1, 2025
@backportbot
Copy link

backportbot bot commented Aug 1, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/52285/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 49d8e29a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52285/stable30

Error: Failed to push branch backport/52285/stable30: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request

Projects

Development

Successfully merging this pull request may close these issues.

[Bug]: (CalDAV) MOVE command incorrectly ignores destination target ID

4 participants