Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 17, 2025

Summary

Allow to unset social media properties (allow empty string).

Checklist

@susnux susnux added bug 3. to review Waiting for reviews regression feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Apr 17, 2025
@susnux susnux added this to the Nextcloud 32 milestone Apr 17, 2025
@susnux susnux requested a review from a team as a code owner April 17, 2025 11:15
@susnux susnux requested review from nfebe, skjnldsv and szaimen and removed request for a team April 17, 2025 11:15
@susnux
Copy link
Contributor Author

susnux commented Apr 17, 2025

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Apr 17, 2025

/backport to stable31

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@skjnldsv
Copy link
Member

/compile

@skjnldsv skjnldsv force-pushed the fix/twitter-fediverse branch from 806d0e6 to 5e2f52d Compare April 25, 2025 10:02
@skjnldsv
Copy link
Member

failure is related

susnux and others added 2 commits April 27, 2025 14:15
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux force-pushed the fix/twitter-fediverse branch from 0eccbc4 to 02da7fd Compare April 27, 2025 12:15
@susnux
Copy link
Contributor Author

susnux commented Apr 27, 2025

failure is related

yes but luckily just the test code :)
✅ fixed it

@susnux susnux enabled auto-merge April 27, 2025 12:15
@susnux susnux merged commit 5862d5a into master Apr 27, 2025
122 checks passed
@susnux susnux deleted the fix/twitter-fediverse branch April 27, 2025 21:00
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cant remove Social Media profiles in User Account

6 participants