Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 17, 2025

@susnux susnux requested a review from a team as a code owner April 17, 2025 10:52
@susnux susnux requested review from ArtificialOwl, skjnldsv and sorbaugh and removed request for a team April 17, 2025 10:52
@susnux susnux added 3. to review Waiting for reviews dependencies php Pull requests that update Php code labels Apr 17, 2025
@susnux susnux requested review from come-nc and nickvergessen and removed request for ArtificialOwl and sorbaugh April 17, 2025 10:53
@susnux susnux force-pushed the chore/update-3rdparty branch from b98ad18 to a60a265 Compare April 17, 2025 10:55
@kesselb kesselb added the pending documentation This pull request needs an associated documentation update label Apr 17, 2025
@come-nc
Copy link
Contributor

come-nc commented Apr 17, 2025

Error: apps/theming/lib/Controller/ThemingController.php:405:20: UndefinedClass: Class, interface or enum named ScssPhp\ScssPhp\Compiler does not exist (see https://psalm.dev/019)

⚠️

@skjnldsv
Copy link
Member

Error: apps/theming/lib/Controller/ThemingController.php:405:20: UndefinedClass: Class, interface or enum named ScssPhp\ScssPhp\Compiler does not exist (see https://psalm.dev/019)

Yeah, I knew we were using it for theming, but when I saw this PR, I thought it got replaced to something else and I forgot lol
@susnux did you had plans for the ThemingController ?

@susnux
Copy link
Contributor Author

susnux commented Apr 18, 2025

@susnux did you had plans for the ThemingController ?

Did not notice we also use it in theming (it was primarily used for legacy scss support).
But after checking that part I would say we can safely remove it, it was only used to generate flat rules from nested syntax.
But as of today (or rather baseline 2023) browsers support nested CSS natively.

Especially as this feature is only used for non-plain theme usage where we only use the dark theme which does not have any custom css which would make problems in old browsers like Chrome 109 (only relevant for EOL Windows 8.1).

@susnux susnux force-pushed the chore/update-3rdparty branch from a60a265 to 0e32402 Compare April 18, 2025 21:27
susnux added 2 commits April 22, 2025 09:51
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the chore/update-3rdparty branch from 0e32402 to f1448fc Compare April 22, 2025 07:51
@susnux susnux removed the pending documentation This pull request needs an associated documentation update label Apr 22, 2025
@skjnldsv skjnldsv merged commit 703af4b into master Apr 22, 2025
215 of 228 checks passed
@skjnldsv skjnldsv deleted the chore/update-3rdparty branch April 22, 2025 08:44
@susnux
Copy link
Contributor Author

susnux commented Apr 29, 2025

/backport f1448fc to stable31

@susnux
Copy link
Contributor Author

susnux commented Apr 29, 2025

(for #52490 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants