fix: handle shares for which the source is deleted when checking if rename target is shared #52098
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ename target is shared Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
artonge,
provokateurin and
sorbaugh
and removed request for
a team
8 tasks
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
artonge
reviewed
Apr 14, 2025
| ['app' => 'files']); | ||
| return false; | ||
| } | ||
| } catch (NotFoundException $e) { |
There was a problem hiding this comment.
What is the behaviour then? Where will the item be moved? I assumed the item won't be moved because it will fail later?
|
Confirmed this works |
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #51767