Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Apr 9, 2025

Backport of #52045

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the backport/52045/stable31 branch from 2d40b6d to d125e81 Compare April 9, 2025 12:39
@icewind1991 icewind1991 marked this pull request as ready for review April 9, 2025 13:42
@skjnldsv skjnldsv mentioned this pull request Apr 10, 2025
14 tasks
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has errors and reduces cache hits drastically

provokateurin
provokateurin previously approved these changes Apr 11, 2025
@nickvergessen nickvergessen dismissed provokateurin’s stale review April 11, 2025 10:39

PR breaks prod, so invalidating any review

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member

added #52128 which should un-break things

This was referenced Apr 15, 2025
@Altahrim Altahrim mentioned this pull request Apr 17, 2025
18 tasks
@AndyScherzinger
Copy link
Member

CI is now all greens, so merge or still blocked?
@nickvergessen @icewind1991 @juliusknorr

@nickvergessen
Copy link
Member

Should test it on our instance again before?

@AndyScherzinger
Copy link
Member

Should test it on our instance again before?

Yes, that be best ( if we can do that 👍 )

@blizzz blizzz mentioned this pull request May 5, 2025
10 tasks
This was referenced Jun 4, 2025
@AndyScherzinger
Copy link
Member

Has errors and reduces cache hits drastically

What to do with this PR @icewind1991 @nickvergessen
Has the hit rate been fixed, tested on c.nc.c or should the PR be discarded?

@nickvergessen
Copy link
Member

This patch significantly worsens the performance on our instance causing a much higher load (2-5x times)

@nextcloud-bot nextcloud-bot mentioned this pull request Jul 3, 2025
6 tasks
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 5, 2025
8 tasks
@nextcloud-command nextcloud-command added the stale Ticket or PR with no recent activity label Aug 9, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 14, 2025
16 tasks
@nextcloud-command nextcloud-command removed the stale Ticket or PR with no recent activity label Aug 15, 2025
This was referenced Sep 4, 2025
@nextcloud-command nextcloud-command added the stale Ticket or PR with no recent activity label Oct 13, 2025
@blizzz blizzz mentioned this pull request Oct 14, 2025
This was referenced Oct 21, 2025
@nextcloud-command nextcloud-command removed the stale Ticket or PR with no recent activity label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants