fix(federation): Don't load the addressbook when resolving a cloud ID #52066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ArtificialOwl,
nfebe and
provokateurin
and removed request for
a team
nickvergessen
force-pushed
the
perf/noid/dont-load-addressbook-on-resolving-cloudid
branch
from
a88fc13 to
09089e0
Compare
provokateurin
approved these changes
Apr 9, 2025
Instead we delay the lookup of the display name until it is actually used Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
perf/noid/dont-load-addressbook-on-resolving-cloudid
branch
from
09089e0 to
6a3c53d
Compare
nickvergessen
requested review from
SystemKeeper and
miaulalala
and removed request for
a team
juliusknorr
approved these changes
Apr 9, 2025
juliusknorr
deleted the
perf/noid/dont-load-addressbook-on-resolving-cloudid
branch
|
/backport to stable31 |
|
/backport to stable30 |
This was referenced Apr 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we delay the lookup of the display name until it is actually used
Summary
This saves the addressbook setup in all usages of Talk where we just resolve the cloud id to properly get the object with split user ID and server URL. The display name is never used in talk as we cache it into the comments and attendees table.
So this saves 5+ queries in all cases that involve federated users.
Display name still properly loads in:
Checklist