fix: more optimized caching for share target verification #52045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
Altahrim,
provokateurin and
skjnldsv
and removed request for
a team
provokateurin
approved these changes
Apr 8, 2025
icewind1991
force-pushed
the
shared-target-verify-cache
branch
from
83d2ab5 to
17b72f4
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
shared-target-verify-cache
branch
from
17b72f4 to
bcbf0e7
Compare
juliusknorr
approved these changes
Apr 9, 2025
|
/backport to stable31 |
2 tasks
|
❌ This might need reverting |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of caching the "validated" status per-share, instead track the latest share (by share id) that is validated.
This uses the fact that once a unique target is generated for the share, new files can't suddenly appear at the share target.
An exception to this is admin-created mount points (groupfolders, external storages, etc). So conflicts with other mount points is always done (but this is very cheap).