-
-
Couldn't load subscription status.
- Fork 4.6k
refactor(RichObjectStrings): Only log error if key or value is not string in validator #52035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(RichObjectStrings): Only log error if key or value is not string in validator #52035
Conversation
|
/backport to stable31 |
…ring in validator Signed-off-by: provokateurin <kate@provokateurin.de>
c0f05a3 to
fd156d3
Compare
| ]); | ||
| $this->addToAssertionCount(2); | ||
|
|
||
| $this->expectException(InvalidObjectExeption::class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add the expected logger call here instead
|
This is causing some log spam on our instance: Some rare cases happened before, but not in that amount. Edit: Seems the new log catches more code paths where is was probably catched before |
|
Yeah it was muted and caught in activity and notifications: server/lib/private/Activity/Event.php Lines 429 to 433 in 3c698c6
server/lib/private/Notification/Notification.php Lines 442 to 446 in 5193579
|

Fixes #51427
Fixes nextcloud/activity#1875
Summary
#47662 was a bit too hard and has caused quite a few issues because there are so many places that are wrong.
While it makes developers more aware, it also breaks a lot of users which is not good. Therefore I'm downgrading it to an error message for now, so developers hopefully still notice it.
Checklist