Skip to content

[stable31] fix(files_reminders): add missing import #51992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025
Merged

[stable31] fix(files_reminders): add missing import #51992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b29207c
fix(files_reminders): add missing import
susnux Apr 4, 2025
55929c9
fix(files_reminders): add l10n to constructor of setup check
susnux Apr 4, 2025
330b14b
chore: lint files_reminders using psalm
susnux Apr 4, 2025
9dcbd76
chore: adjust syntax for app manager
susnux Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/files_reminders/composer/composer/autoload_classmap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,5 @@
'OCA\\FilesReminders\\Model\\RichReminder' => $baseDir . '/../lib/Model/RichReminder.php',
'OCA\\FilesReminders\\Notification\\Notifier' => $baseDir . '/../lib/Notification/Notifier.php',
'OCA\\FilesReminders\\Service\\ReminderService' => $baseDir . '/../lib/Service/ReminderService.php',
'OCA\\FilesReminders\\SetupChecks\\NeedNotificationsApp' => $baseDir . '/../lib/SetupChecks/NeedNotificationsApp.php',
);
1 change: 1 addition & 0 deletions apps/files_reminders/composer/composer/autoload_static.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class ComposerStaticInitFilesReminders
'OCA\\FilesReminders\\Model\\RichReminder' => __DIR__ . '/..' . '/../lib/Model/RichReminder.php',
'OCA\\FilesReminders\\Notification\\Notifier' => __DIR__ . '/..' . '/../lib/Notification/Notifier.php',
'OCA\\FilesReminders\\Service\\ReminderService' => __DIR__ . '/..' . '/../lib/Service/ReminderService.php',
'OCA\\FilesReminders\\SetupChecks\\NeedNotificationsApp' => __DIR__ . '/..' . '/../lib/SetupChecks/NeedNotificationsApp.php',
);

public static function getInitializer(ClassLoader $loader)
Expand Down
1 change: 1 addition & 0 deletions apps/files_reminders/lib/AppInfo/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
use OCA\FilesReminders\Listener\SabrePluginAddListener;
use OCA\FilesReminders\Listener\UserDeletedListener;
use OCA\FilesReminders\Notification\Notifier;
use OCA\FilesReminders\SetupChecks\NeedNotificationsApp;
use OCP\AppFramework\App;
use OCP\AppFramework\Bootstrap\IBootContext;
use OCP\AppFramework\Bootstrap\IBootstrap;
Expand Down
2 changes: 1 addition & 1 deletion apps/files_reminders/lib/Notification/Notifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function prepare(INotification $notification, string $languageCode): INot
[
'name' => [
'type' => 'highlight',
'id' => $node->getId(),
'id' => (string)$node->getId(),
'name' => $node->getName(),
],
],
Expand Down
4 changes: 3 additions & 1 deletion apps/files_reminders/lib/SetupChecks/NeedNotificationsApp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,17 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OCA\DAV\SetupChecks;
namespace OCA\FilesReminders\SetupChecks;

use OCP\App\IAppManager;
use OCP\IL10N;
use OCP\SetupCheck\ISetupCheck;
use OCP\SetupCheck\SetupResult;

class NeedNotificationsApp implements ISetupCheck {
public function __construct(
private IAppManager $appManager,
private IL10N $l10n,
) {
}

Expand Down
6 changes: 6 additions & 0 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,12 @@
<code><![CDATA[test]]></code>
</TooManyArguments>
</file>
<file src="apps/files_reminders/lib/Model/RichReminder.php">
<ConstructorSignatureMismatch>
<code><![CDATA[public function __construct(]]></code>
<code><![CDATA[public function __construct(]]></code>
</ConstructorSignatureMismatch>
</file>
<file src="apps/files_sharing/lib/Controller/ShareAPIController.php">
<RedundantCast>
<code><![CDATA[(int)$code]]></code>
Expand Down
1 change: 1 addition & 0 deletions psalm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
<directory name="apps/federation"/>
<directory name="apps/files"/>
<directory name="apps/files_external"/>
<directory name="apps/files_reminders"/>
<directory name="apps/files_sharing"/>
<directory name="apps/files_trashbin"/>
<directory name="apps/files_versions"/>
Expand Down
Loading