Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 4, 2025

Summary

Ensure enabled themes are always set on the template.
isEnabledForUser is not needed since Nextcloud 22 as this app is force-enabled for all users.
Also class_exists is not needed as this is shipped since 22. Moreover the check prevented the fallback to enforced theme when no user is logged in.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Apr 4, 2025
@susnux susnux added this to the Nextcloud 31.0.3 milestone Apr 4, 2025
@susnux
Copy link
Contributor Author

susnux commented Apr 4, 2025

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Apr 4, 2025

/backport to stable29

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/31-template-layout branch from 69af9a6 to 00580b3 Compare April 4, 2025 07:23
@AndyScherzinger AndyScherzinger merged commit 511a8e2 into stable31 Apr 4, 2025
200 of 215 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/31-template-layout branch April 4, 2025 07:59
@backportbot
Copy link

backportbot bot commented Apr 4, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/51929/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 00580b36

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51929/stable29

Error: Failed to check for changes with origin/stable29: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Apr 4, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/51929/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 00580b36

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51929/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants