-
-
Couldn't load subscription status.
- Fork 4.6k
fix: ensure enabled themes are set on the template #51929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable30 |
|
/backport to stable29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the problem
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
69af9a6 to
00580b3
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/51929/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 00580b36
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51929/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/51929/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 00580b36
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51929/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Ensure enabled themes are always set on the template.
isEnabledForUseris not needed since Nextcloud 22 as this app is force-enabled for all users.Also
class_existsis not needed as this is shipped since 22. Moreover the check prevented the fallback to enforced theme when no user is logged in.Checklist