fix: improve handling of newFolder race condition handling #51920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport! to stable29 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
newfolder-race-improvements
branch
from
8600151 to
99364ad
Compare
icewind1991
requested review from
artonge,
come-nc and
nfebe
and removed request for
a team
artonge
approved these changes
May 12, 2025
come-nc
approved these changes
May 13, 2025
|
/backport to stable30 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a race condition happens, we need to ensure the folder also exists in cache before we return.
To test:
uploadsfolder for an existing user from both disk and cache)Without this patch, some of the uploads will fail sometimes (failure rate will depend on random factors), with this patch all uploads always succeed