[stable29] fix(settings): Handle email change restriction separately from display name change restriction #51899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
AndyScherzinger,
provokateurin,
skjnldsv and
susnux
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $allowDisplayNameChange = $this->config->getSystemValue('allow_user_to_change_display_name', true); | ||
| if ($allowDisplayNameChange === true && ( | ||
| $targetUser->getBackend() instanceof ISetDisplayNameBackend | ||
| || $targetUser->getBackend()->implementsActions(Backend::SET_DISPLAYNAME) |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| $allowDisplayNameChange = $this->config->getSystemValue('allow_user_to_change_display_name', true); | ||
| if ($allowDisplayNameChange === true && ( | ||
| $targetUser->getBackend() instanceof ISetDisplayNameBackend | ||
| || $targetUser->getBackend()->implementsActions(Backend::SET_DISPLAYNAME) |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
| $allowDisplayNameChange = $this->config->getSystemValue('allow_user_to_change_display_name', true); | ||
| if ($allowDisplayNameChange !== false && ( | ||
| $targetUser->getBackend() instanceof ISetDisplayNameBackend | ||
| || $targetUser->getBackend()->implementsActions(Backend::SET_DISPLAYNAME) |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| $allowDisplayNameChange = $this->config->getSystemValue('allow_user_to_change_display_name', true); | ||
| if ($allowDisplayNameChange !== false && ( | ||
| $targetUser->getBackend() instanceof ISetDisplayNameBackend | ||
| || $targetUser->getBackend()->implementsActions(Backend::SET_DISPLAYNAME) |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
susnux
force-pushed
the
backport/51745/stable29
branch
from
c213284 to
b0a948e
Compare
susnux
approved these changes
Apr 3, 2025
| $accountParameters = [ | ||
| 'avatarChangeSupported' => $user->canChangeAvatar(), | ||
| 'displayNameChangeSupported' => $user->canChangeDisplayName(), | ||
| 'emailChangeSupported' => $user->canChangeEmail(), |
Check notice
Code scanning / Psalm
UndefinedInterfaceMethod Note
…y name change restriction Co-authored-by: provokateurin <kate@provokateurin.de> Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Louis <louis@chmn.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/51745/stable29
branch
from
b0a948e to
f1e3312
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
approved these changes
Apr 3, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #51745
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.