Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 2, 2025

Fix #51624
Best fix is with nextcloud-libraries/nextcloud-vue#6683, but for backports and the fact that we want this in today, let's use a setTimeout until deployed 🚀

Context

  • we have one NcActions per file entry,
  • while having a file action opened,
  • and when opening a new one, the menu flickers.
  • Additionally, when closing the menu, it also briefly shown fading at the menu button position instead of the mouse cursor. It should only fade and complete its animation at its current location.

Explanations

The apply-hide event was wrongly used (because we have our own additional method called after-hide
The timing was also wrong (the closed event was triggered BEFORE the popup was actually hidden in the dom.

Solution

  • We need to wait for our animation to finish, currently it is not done.
  • We also need to properly reset the global floating position (cursor) ONLY if there isn't another menu opened

@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews high labels Apr 2, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Apr 2, 2025
@skjnldsv skjnldsv self-assigned this Apr 2, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner April 2, 2025 11:00
@skjnldsv skjnldsv requested review from artonge, nfebe, sorbaugh and susnux and removed request for a team April 2, 2025 11:00
@susnux
Copy link
Contributor

susnux commented Apr 2, 2025

but for backports and the fact that we want this in today,

8.24 will release today so should work with it as well

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 2, 2025

but for backports and the fact that we want this in today,

8.24 will release today so should work with it as well

but I don't wanna update all stablexx branches with latest nc/vue, will take forever to be merged as always

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 2, 2025

/compile rebase

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 2, 2025
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 2, 2025

/backport! to stable31

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 2, 2025

/backport! to stable30

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 2, 2025

/backport! to stable29

skjnldsv and others added 2 commits April 2, 2025 14:39
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/files-actions-menu-position branch from 2b330cb to 2f58abb Compare April 2, 2025 14:41
@skjnldsv skjnldsv merged commit 90b8838 into master Apr 2, 2025
119 of 121 checks passed
@skjnldsv skjnldsv deleted the fix/files-actions-menu-position branch April 2, 2025 15:36
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Jumpy right-click menu in file-list

6 participants