Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Apr 1, 2025

Summary

Follow-up of #51692 which broke a query in federatedfilesharing.
Because blueprint calls getAllShares here: https://github.com/icewind1991/blueprint/blob/00504403f76cb2a09efd0d16793575055e6f63cb/lib/Blueprint/ShareLoader.php#L43
The performance workflow was failing on blueprint step on PR on stable30, as DI would crash on the bad query when building this class.

Checklist

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added bug 3. to review Waiting for reviews labels Apr 1, 2025
@come-nc come-nc added this to the Nextcloud 30.0.9 milestone Apr 1, 2025
@come-nc come-nc self-assigned this Apr 1, 2025
@come-nc
Copy link
Contributor Author

come-nc commented Apr 1, 2025

The step is still failing, and was not failing on #51692.
My theory is that this comes from the fact that the performance step compares target branch with PR, so it needs to successfully install blueprint on target branch, not PR branch.
So this should be force merged.

@come-nc come-nc changed the title fix(federatedfilesharing): Fix incorrect SQL query [stable30] fix(federatedfilesharing): Fix incorrect SQL query Apr 1, 2025
@come-nc come-nc merged commit 30c2a7d into stable30 Apr 1, 2025
182 of 195 checks passed
@come-nc come-nc deleted the fix/fix-incorrect-query-in-federatedshareprovider branch April 1, 2025 10:12
@Altahrim Altahrim mentioned this pull request Apr 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants