Skip to content

fix(phpunit10): Migrate away from PHPUnit at() calls #51768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2025
Merged

fix(phpunit10): Migrate away from PHPUnit at() calls #51768

merged 3 commits into from
Mar 31, 2025

Conversation

@nickvergessen
Copy link
Member

nickvergessen and others added 2 commits March 27, 2025 23:23
@nickvergessen
fix(phpunit10): Migrate away from PHPUnit at() calls
5a167fd 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@susnux @nickvergessen
fix: Adjust data provider name
9ccb701 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Mar 27, 2025
@nickvergessen nickvergessen added this to the Nextcloud 32 milestone Mar 27, 2025
@nickvergessen nickvergessen self-assigned this Mar 27, 2025
@nickvergessen nickvergessen requested a review from a team as a code owner March 27, 2025 22:27
@nickvergessen nickvergessen requested review from come-nc, icewind1991, nfebe and susnux and removed request for a team March 27, 2025 22:27
@susnux

This comment was marked as resolved.

Sign in to view
@nickvergessen nickvergessen force-pushed the techdebt/noid/prepare-phpunit10 branch from f0b2153 to 8bc21ee Compare March 28, 2025 11:52
@nickvergessen
fix(phpunit): Remove some more withConsecutive calls
522be60 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/prepare-phpunit10 branch from 8bc21ee to 522be60 Compare March 31, 2025 07:43
come-nc
come-nc reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would feel better if we can avoid expecting a specific default value for config keys, otherwise good job!

@nickvergessen nickvergessen merged commit aee2f2d into master Mar 31, 2025
206 of 212 checks passed
@nickvergessen nickvergessen deleted the techdebt/noid/prepare-phpunit10 branch March 31, 2025 14:04
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @susnux @come-nc @skjnldsv