perf(sharing): Use oc_share.item_type IN instead of OR equals #51669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
requested review from
come-nc,
nfebe and
provokateurin
and removed request for
a team
provokateurin
approved these changes
Mar 24, 2025
…equals to improve performance by using the db index Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
refactor/use-in-instead-of-or
branch
from
eb72f1d to
b464469
Compare
marcelklehr
changed the title
come-nc
approved these changes
Mar 25, 2025
provokateurin
added
3. to review
|
Do we backport this? |
|
I'd say no, as nobody has been complaining about these exact queries causing performance problems. |
|
I have a ticket from a customer where these are problematic among others. They are on 29 |
|
/backport to stable31 |
|
/backport to stable30 |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to improve performance by using the db index
Summary
We found a query like this that doesn't use the available index and seems to cause a table scan, which seems to be due to the use of OR instead of IN.
Thanks to @Altahrim for figuring this out.
Checklist