Skip to content

fix(IFilenameValidator): correctly handle case insensitivity #51611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix(IFilenameValidator): correctly handle case insensitivity #51611

merged 1 commit into from
Mar 24, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 20, 2025 •
edited
Loading

Summary

  • forbidden names and forbidden base names are case insensitive so we need to check all lowercase here.
  • add test that config value is also read case insensitive.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. labels Mar 20, 2025
@susnux susnux added this to the Nextcloud 32 milestone Mar 20, 2025
@susnux susnux requested a review from a team as a code owner March 20, 2025 18:04
@susnux susnux requested review from Altahrim, icewind1991 and sorbaugh and removed request for a team March 20, 2025 18:05
@susnux
Copy link
Contributor Author

susnux commented Mar 20, 2025

/backport to stable31

@susnux
Copy link
Contributor Author

susnux commented Mar 20, 2025

/backport to stable30

@susnux
fix(IFilenameValidator): correctly handle case insensitivity
254dd85 
- forbidden names and forbidden base names are case **insensitive**
  so we need to check all lowercase here.
- add test that config value is also read case insensitive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/file-name-validator-case-sensitivity branch from bde1194 to 254dd85 Compare March 21, 2025 00:01
@susnux susnux requested review from come-nc and removed request for sorbaugh March 21, 2025 07:34
@susnux susnux merged commit 214ac4c into master Mar 24, 2025
196 of 204 checks passed
@susnux susnux deleted the fix/file-name-validator-case-sensitivity branch March 24, 2025 11:46
This was referenced Mar 24, 2025
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug hotspot: filename handling Filenames - invalid, portable, blacklisting, etc.

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux @AndyScherzinger @come-nc @skjnldsv