fix: Use default share folder of the user on share accept

[come-nc]

• Resolves: Shares to a local group does not honor the user setting: "Set default folder for accepted shares" #40069

Summary

When sharing to a group, it was not respecting the default share folder of each user.
The code was trying to set the target on the group share on creation, while it needs to be done on acceptance for each user, as each user may have a different configuration.

I’m wondering if we should not do the same for user shares as well and only set target when accepting, and also whether it’s expected that we set target for all types of shares. What’s the target for on link shares or share by mail? But maybe it’s needed for federated shares or whatever so I did not remove that.

• Check if federated shares still end up in the configured folder
• Check if other share types need it

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ShGKme]

/backport to stable28

[ShGKme]

/backport! to stable28

[come-nc]

@susnux @icewind1991 @artonge
Pinging you to get feedback on this, what is the correct way to know whether $share->getSharedWith() is a local user or not? If it’s not we cannot call getUserValue with it. Current version filters only IShare::TYPE_USER but I guess there are other share types which targets a local user.

[icewind1991]

I believe TYPE_USERGROUP, TYPE_GUEST, TYPE_USERROOM and TYPE_DECK_USER are also local users, but that will need to be verified.

Probably makes sense to add a getSharedWithUser(): ?IUser (or similar) to IShare so we only need to have the logic in once place

[come-nc]

I believe TYPE_USERGROUP, TYPE_GUEST, TYPE_USERROOM and TYPE_DECK_USER are also local users, but that will need to be verified.

• TYPE_USERGROUP should only be created by DefaultShareProvider::createUserSpecificGroupShare, so that’s covered.
• TYPE_USERROOM this one is managed by Talk and does not respect the default share folder on purpose I think
• TYPE_GUEST: I cannot find any code creating shares with this type, even in the guests application. What is this type used for?
• TYPE_DECK_USER: Looks like it’s the same as the first two, managed in an application. If deck wants to put the share in the user configured folder, it will need to implement it on its own.

Probably makes sense to add a getSharedWithUser(): ?IUser (or similar) to IShare so we only need to have the logic in once place

That would be cleaner but would make backporting hard, so I would say for now a simple solution is needed.

According to the type list above @icewind1991 , I believe this PR can be reviewed and merged as-is, as the only known type handled by Share20\Manager::createShare to target a user appears to be TYPE_USER.

[come-nc]

/backport to stable31

[come-nc]

/backport to stable30

[come-nc]

/backport to stable29