fix: adjust webpack nonce generation #51524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
susnux
requested review from
artonge and
marcelklehr
and removed request for
sorbaugh
|
Are community app developers aware of this? I was not |
skjnldsv
approved these changes
Apr 5, 2025
artonge
approved these changes
Apr 7, 2025
It is in the developer upgrade guides since Nextcloud 30 👀 But only relevant if you use Webpack, our vite config was adjusted back then to directly make use of it. |
some leftovers where the request token is used instead of the CSP nonce. in general this makes not much difference - but there are some cases where those values differ. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/webpack-nonce
branch
from
d839225 to
47734c2
Compare
|
/compile |
|
/backport to stable31 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
some leftovers where the request token is used instead of the CSP nonce. in general this makes not much difference - but there are some cases where those values differ.
Checklist