Skip to content

fix(webauthn): adjust for updated library and add tests #51521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2025
Merged

fix(webauthn): adjust for updated library and add tests #51521

merged 4 commits into from
Mar 19, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 17, 2025 •
edited
Loading

Summary

  • Adjust code to updated library which was a breaking change
  • Drop hard requirement on bcmath and gmp as this is not needed anymore since 3 years (allows us to test it in Cypress)
  • Adjust Cypress to run in secure context (localhost) to allow testing webauthn
  • Add Cypress tests

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Mar 17, 2025
@susnux
Copy link
Contributor Author

susnux commented Mar 17, 2025

/backport to stable31

@susnux susnux marked this pull request as ready for review March 17, 2025 11:02
@susnux susnux requested review from a team as code owners March 17, 2025 11:02
@susnux susnux requested review from Pytal, artonge and szaimen and removed request for a team March 17, 2025 11:02
@susnux susnux requested review from ArtificialOwl and come-nc and removed request for a team March 17, 2025 11:02
This was referenced Mar 17, 2025
Closed
Merged
come-nc
come-nc approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not review frontend.

@susnux
Copy link
Contributor Author

susnux commented Mar 18, 2025

/compile

@susnux susnux force-pushed the fix/webauthn branch 2 times, most recently from 3910418 to cbc533b Compare March 18, 2025 16:04
@szaimen szaimen removed their request for review March 18, 2025 16:08
susnux added 4 commits March 19, 2025 11:19
@susnux
fix(core): adjust fronend code for changes in webauthn library
60dd89e 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(webauthn): do not require bcmath or gmp - not needed anymore
a243e9c 
The extensions are not required anymore but only recommended for
performance. See also:
web-auth/webauthn-framework#213

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test: make cypress run in secure context and add WebAuthn tests
45cfaa1 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: compile assets
8cf4920 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 37f8beb into master Mar 19, 2025
198 of 203 checks passed
@susnux susnux deleted the fix/webauthn branch March 19, 2025 11:33
@backportbot backportbot bot mentioned this pull request Mar 19, 2025
Merged
2 tasks
@Bandie Bandie mentioned this pull request Mar 19, 2025
Closed
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner automatically assigned from nextcloud/server-frontend

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: authentication

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: FIDO2/webauthn stopped working after update

5 participants

@susnux @artonge @come-nc @skjnldsv