fix(dav): allow uploading of files with long filenames #51491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
icewind1991,
provokateurin,
skjnldsv and
sorbaugh
and removed request for
a team and
sorbaugh
susnux
added
3. to review
susnux
commented
Apr 22, 2025
susnux
commented
Apr 22, 2025
susnux
commented
Apr 22, 2025
susnux
commented
Apr 22, 2025
come-nc
approved these changes
Apr 22, 2025
skjnldsv
approved these changes
Apr 22, 2025
Reduce nesting and drop duplicated sections. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
A filename must be less or equal 255 characters, but when adding the `.part` and `.ocfiletransfer` extensions we might overflow this limit. So we should also use filename hashes for uploading when the file has a long filename, similar like when we are uploading to the user storage directly. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
rebased to squash fixup commits. |
provokateurin
approved these changes
Apr 22, 2025
|
/backport to stable31 |
|
/backport to stable30 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A filename must be less or equal 255 characters, but when adding the
.partand.ocfiletransferextensions we might overflow this limit.So we should also use filename hashes for uploading when the file has a
long filename, similar like when we are uploading to the user storage directly.
TODO
oc_filecache.name. Meaning to increase it from 250 to 255. cc @icewind1991Tests
Before
After
Checklist