Skip to content

feat(bulk-upload): change the default to disabled as there are still some bugs present #51431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

feat(bulk-upload): change the default to disabled as there are still some bugs present #51431

merged 1 commit into from
Apr 11, 2025

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Mar 12, 2025

@szaimen szaimen added bug 3. to review Waiting for reviews labels Mar 12, 2025
@szaimen szaimen added this to the Nextcloud 32 milestone Mar 12, 2025
@szaimen szaimen requested a review from a team as a code owner March 12, 2025 11:17
@szaimen szaimen requested review from ArtificialOwl, artonge and come-nc and removed request for a team March 12, 2025 11:17
@szaimen
Copy link
Contributor Author

szaimen commented Mar 12, 2025

/backport to stable31

@szaimen
Copy link
Contributor Author

szaimen commented Mar 12, 2025

/backport to stable30

@szaimen
Copy link
Contributor Author

szaimen commented Mar 12, 2025

Setting to draft for now as discussed with @Rello

@szaimen szaimen marked this pull request as draft March 12, 2025 11:21
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 12, 2025
@provokateurin
Copy link
Member

Hm it seems it's the client that is broken and not the server, so it should be disabled in the client instead?

@szaimen
Copy link
Contributor Author

szaimen commented Apr 10, 2025

Hm it seems it's the client that is broken and not the server, so it should be disabled in the client instead?

I just discussed this with @Rello and It will disabled in the future in the desktop client. However to also cover outdated clients, it is necessary to disable it here as well.

@szaimen szaimen marked this pull request as ready for review April 10, 2025 13:28
@szaimen
feat(bulk-upload): change the default to disabled as there are still …
5e6478f 
…some bugs present

Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/disable-bulk-upload branch from 92022d5 to 5e6478f Compare April 10, 2025 13:28
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 10, 2025
@szaimen
Copy link
Contributor Author

szaimen commented Apr 10, 2025

So ready for review!

provokateurin
provokateurin approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️

@tobiasKaminsky tobiasKaminsky merged commit 5e9ebe4 into master Apr 11, 2025
194 of 205 checks passed
@tobiasKaminsky tobiasKaminsky deleted the enh/noid/disable-bulk-upload branch April 11, 2025 09:22
This was referenced Apr 11, 2025
Merged
Merged
@artonge
Copy link
Contributor

artonge commented Apr 11, 2025 •
edited
Loading

I don't get why this is merged. The desktop client has a much more flexible release schedule, and I would assume that clients get upgraded much sooner than servers. Also, it would have been better to change the capability name instead of disabling it altogether, this would have allowed futur desktop client versions improve their logic. We now have arbitrary server versions for which it does not work for no reason.

@artonge artonge mentioned this pull request Apr 11, 2025
Merged
@provokateurin
Copy link
Member

I agree with @artonge, like I said before already.

@susnux susnux added the pending documentation This pull request needs an associated documentation update label Apr 14, 2025
@joshtrichards joshtrichards added the hotspot: file transfer performance upload & download performance related optimizations label Apr 16, 2025
@szaimen szaimen removed the pending documentation This pull request needs an associated documentation update label Apr 18, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Rello Rello Rello approved these changes

@provokateurin provokateurin provokateurin approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug hotspot: file transfer performance upload & download performance related optimizations

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

10 participants

@szaimen @provokateurin @artonge @nickvergessen @Rello @joshtrichards @susnux @tobiasKaminsky @skjnldsv