[stable31] fix(singularandpluralfiles):implemented ternary operator to handle si… #51419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
3. to review
skjnldsv
approved these changes
Mar 12, 2025
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/51031/stable31
branch
from
dd8f138 to
f258b22
Compare
susnux
approved these changes
Mar 12, 2025
nickvergessen
requested changes
Mar 12, 2025
| // if we're here, we have a mix of failed and successful files | ||
| showError(t('files', '{count} files could not be converted', { count: failed.length })) | ||
| showSuccess(t('files', '{count} files successfully converted', { count: fileIds.length - failed.length })) | ||
| showError(n('files', 'One file could not be converted', '%n files could not be converted', failed.length)) |
There was a problem hiding this comment.
Please use the placeholder also in singular (even if you split the === 1 case of above) to keep it more logical for translators of languages where they have no "plural" for 1, but e.g. the first plural rule is for numbers 1-3
There was a problem hiding this comment.
Should be already done on master not only on the backport
Merged
This was referenced Jun 4, 2025
Merged
Merged
Merged
Co-authored-by: Caitlin Jordan <jordan.cait17@gmail.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
force-pushed
the
backport/51031/stable31
branch
from
f258b22 to
0314ccd
Compare
|
Thanks for the help here, it was still on my todo, but down the priority list :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #51031
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.