-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(federatedfilesharing): warn when enabling lookup server data upload #51352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! LGTM but did not test
|
We should have take this opportunity to switch to More seriously, we should ignore value from |
We can do this in a follow up. |
d03d0f4 to
60e1132
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
60e1132 to
b22358f
Compare
Summary
Checklist