Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 8, 2025

  • Resolves: #

Summary

  1. Switch default from true to false for user data upload to lookup server
  2. Add warning when enabling the upload to make sure the admin understands what it will cause.

grafik

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Mar 8, 2025
@susnux susnux added this to the Nextcloud 32 milestone Mar 8, 2025
@susnux susnux requested a review from nickvergessen March 8, 2025 20:19
@susnux susnux requested a review from AndyScherzinger March 9, 2025 23:03
@susnux susnux marked this pull request as ready for review March 9, 2025 23:03
@susnux susnux requested review from a team as code owners March 9, 2025 23:03
@susnux susnux requested review from nfebe, skjnldsv, szaimen and yemkareems and removed request for a team March 9, 2025 23:03
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! LGTM but did not test

@ArtificialOwl
Copy link
Member

ArtificialOwl commented Mar 10, 2025

We should have take this opportunity to switch to IAppConfig and ConfigLexicon :-)

More seriously, we should ignore value from 'lookupServerUploadEnabled' if 'lookup_server' 'gs.enabled' exists and is set (for a smooth upgrade on Global Scale)

@nickvergessen
Copy link
Member

We should have take this opportunity to switch to IAppConfig and ConfigLexicon :-)

We can do this in a follow up.
I think the original change needs backporting a bit further than those things exist

@susnux susnux force-pushed the fix/lookup-server-connector branch from d03d0f4 to 60e1132 Compare March 13, 2025 20:45
@susnux susnux changed the title fix(federatedfilesharing): disable user data upload by default fix(federatedfilesharing): warn when enabling lookup server data upload Mar 13, 2025
susnux added 2 commits March 21, 2025 15:14
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/lookup-server-connector branch from 60e1132 to b22358f Compare March 21, 2025 14:54
@susnux susnux merged commit e3aacbb into master Mar 21, 2025
130 of 132 checks passed
@susnux susnux deleted the fix/lookup-server-connector branch March 21, 2025 16:41
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants