Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 7, 2025

Backport of PR #51082

@backportbot backportbot bot added 3. to review Waiting for reviews feature: dav pending documentation This pull request needs an associated documentation update labels Mar 7, 2025
@backportbot backportbot bot added this to the Nextcloud 31.0.1 milestone Mar 7, 2025
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding #51398

use OCP\EventDispatcher\IWebhookCompatibleEvent;

/**
* @since 32.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @since 32.0.0
* @since 31.0.2

everywhere? or what is the current state of the @since backporting strategy

@blizzz blizzz mentioned this pull request Mar 12, 2025
14 tasks
@Altahrim Altahrim mentioned this pull request Mar 18, 2025
20 tasks
@blizzz blizzz mentioned this pull request Mar 19, 2025
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on including #51398 to have fewer surprises in the patch update.

@edward-ly could you please take care of that?

@edward-ly
Copy link
Contributor

👍 on including #51398 to have fewer surprises in the patch update.

@edward-ly could you please take care of that?

Commit has already been added here?

edward-ly and others added 3 commits March 31, 2025 10:26
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@edward-ly edward-ly force-pushed the backport/51082/stable31 branch from e37e6ad to bcb2c50 Compare March 31, 2025 17:27
@nickvergessen nickvergessen changed the title [stable31] feat(dav)!: add webhook compatibility for calendar object events [stable31] feat(dav): add webhook compatibility for calendar object events Apr 1, 2025
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the since question fine by me. Pinged Christoph for a comment, but approving already.

@nickvergessen nickvergessen merged commit 4d75eea into stable31 Apr 1, 2025
184 of 188 checks passed
@nickvergessen nickvergessen deleted the backport/51082/stable31 branch April 1, 2025 10:05
@Altahrim Altahrim mentioned this pull request Apr 3, 2025
2 tasks
@skjnldsv skjnldsv removed the pending documentation This pull request needs an associated documentation update label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants