Skip to content

[stable29] Add LDAP test settings command #51305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 24, 2025
Merged

[stable29] Add LDAP test settings command #51305

merged 5 commits into from
Mar 24, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 6, 2025 •
edited by max-nextcloud
Loading

Backport of #50691

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from come-nc and max-nextcloud March 6, 2025 11:53
@backportbot backportbot bot added this to the Nextcloud 29.0.13 milestone Mar 6, 2025
@max-nextcloud max-nextcloud mentioned this pull request Mar 6, 2025
Merged
13 tasks
@max-nextcloud max-nextcloud changed the title [stable29] [stable30] Add LDAP test settings command [stable29] Add LDAP test settings command Mar 6, 2025
@backportbot backportbot bot force-pushed the backport/50691/stable29 branch from f9bdfbd to d80858c Compare March 24, 2025 12:47
come-nc added 4 commits March 24, 2025 14:08
@come-nc @max-nextcloud
feat(user_ldap): upstream common code into Proxy class and add public…
96cb85e 
… getters for backends

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @max-nextcloud
feat(user_ldap): Add command test-user-settings to test LDAP user set…
f9bb4a7 
…tings

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @max-nextcloud
fix(user_ldap): Remove redundant if check
39a1cda 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @max-nextcloud
feat(user_ldap): Add a --clearcache option to ldap:test-user-settings
9cf3d24 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the backport/50691/stable29 branch from d80858c to 9cf3d24 Compare March 24, 2025 13:10
@max-nextcloud max-nextcloud marked this pull request as ready for review March 24, 2025 13:10
@max-nextcloud max-nextcloud requested a review from blizzz as a code owner March 24, 2025 13:10
max-nextcloud
max-nextcloud approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the backport and compared the results.

@max-nextcloud
chore(psalm): update baseline
b4f57d2 
Signed-off-by: Max <max@nextcloud.com>
come-nc
come-nc approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works.

@max-nextcloud max-nextcloud merged commit cd91e09 into stable29 Mar 24, 2025
189 of 191 checks passed
@max-nextcloud max-nextcloud deleted the backport/50691/stable29 branch March 24, 2025 14:06
@Altahrim Altahrim mentioned this pull request Apr 3, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: ldap

Projects

None yet

Milestone

Nextcloud 29.0.15

Development

Successfully merging this pull request may close these issues.

5 participants

@come-nc @max-nextcloud @blizzz @solracsf