Skip to content

[stable29] fix(test): Add missing data-cy attribute for file actions #51284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 6, 2025
Merged

[stable29] fix(test): Add missing data-cy attribute for file actions #51284

merged 5 commits into from
Mar 6, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 5, 2025 •
edited by artonge
Loading

Backport of #51281

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, nfebe and susnux March 5, 2025 12:40
@backportbot backportbot bot added bug 3. to review Waiting for reviews feature: files tests Related to tests labels Mar 5, 2025
@backportbot backportbot bot added this to the Nextcloud 29.0.13 milestone Mar 5, 2025
@artonge artonge changed the title [stable29] [stable30] fix(test): Add missing data-cy attribute for file actions [stable29] fix(test): Add missing data-cy attribute for file actions Mar 5, 2025
@artonge
Copy link
Contributor

artonge commented Mar 5, 2025

/compile amend /

@artonge artonge marked this pull request as ready for review March 5, 2025 12:44
@artonge artonge requested a review from skjnldsv as a code owner March 5, 2025 12:44
@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

@artonge does the command will remove the [skip ci] ? Otherwise you need to amend the commit to remove it ;)

@nextcloud-command nextcloud-command force-pushed the backport/51281/stable29 branch from fde7ccb to 167553b Compare March 5, 2025 13:04
@blizzz blizzz mentioned this pull request Mar 5, 2025
Merged
13 tasks
@artonge
fix(test): Add missing data-cy attribute for file actions
98d9442 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge force-pushed the backport/51281/stable29 branch from 167553b to 98d9442 Compare March 6, 2025 08:47
artonge added 4 commits March 6, 2025 10:24
@artonge
test: Expose set and getVariable in Cypress tests
e9cfb87 
Partial cherry pick of 4a90d53

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
chore(tests): Fix using save/restore state in cypress
4e65026 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
fix(test): Escape quotes in runOccCommand argument
ad5aa6c 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
test: Improve stability of live photo e2ee tests
9730f86 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the backport/51281/stable29 branch from 3eeba63 to 9730f86 Compare March 6, 2025 10:28
@skjnldsv skjnldsv merged commit d1bdd95 into stable29 Mar 6, 2025
185 checks passed
@skjnldsv skjnldsv deleted the backport/51281/stable29 branch March 6, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@nfebe nfebe Awaiting requested review from nfebe

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews bug feature: files tests Related to tests

Projects

None yet

Milestone

Nextcloud 29.0.13

Development

Successfully merging this pull request may close these issues.

4 participants

@artonge @susnux @skjnldsv