Skip to content

fix: pass hide download attribute while creating the share to fix github issue 50788 #51250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 19, 2025
Merged

fix: pass hide download attribute while creating the share to fix github issue 50788 #51250

merged 5 commits into from
Mar 19, 2025

Conversation

@yemkareems
Copy link
Contributor

@yemkareems yemkareems commented Mar 5, 2025 •
edited by susnux
Loading

Summary

TODO

  • ...

Checklist

@yemkareems yemkareems added the 3. to review Waiting for reviews label Mar 5, 2025
@yemkareems yemkareems self-assigned this Mar 5, 2025
@yemkareems
Copy link
Contributor Author

/compile

@susnux susnux mentioned this pull request Mar 5, 2025
Closed
@susnux susnux marked this pull request as ready for review March 5, 2025 20:36
@susnux susnux requested a review from a team as a code owner March 5, 2025 20:36
@susnux susnux requested review from Pytal, skjnldsv and szaimen and removed request for a team March 5, 2025 20:36
@susnux susnux added this to the Nextcloud 32 milestone Mar 5, 2025
@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from 36c1585 to 8ef5647 Compare March 5, 2025 23:28
@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

/compile

@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from eeafeee to bba7972 Compare March 6, 2025 07:41
@szaimen szaimen removed their request for review March 6, 2025 10:11
@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from bba7972 to ff2851b Compare March 13, 2025 10:36
@susnux

This comment was marked as resolved.

Sign in to view
@susnux
Copy link
Contributor

susnux commented Mar 13, 2025

/backport to stable31

@susnux
Copy link
Contributor

susnux commented Mar 13, 2025

/backport to stable30

@susnux
Copy link
Contributor

susnux commented Mar 13, 2025

/backport to stable29

@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from 5e984e4 to c460ffd Compare March 13, 2025 11:03
@susnux

This comment was marked as outdated.

Sign in to view
@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch 3 times, most recently from 53dc309 to add64e9 Compare March 15, 2025 12:42
susnux
susnux reviewed Mar 15, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests work - should be ok now

@yemkareems @susnux
fix: pass hide download attribute while creating the share to fix git…
92a9339 
…hub issue 50788

Signed-off-by: yemkareems <yemkareems@gmail.com>
susnux and others added 4 commits March 18, 2025 16:00
@susnux
fix(files_sharing): ugly hacks to update permissions on share creation
a8358da 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(files_sharing): make sure IDs are unique for HTML elements
57c3153 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test: add cypress tests for sharing download permission
30f3cbf 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command @susnux
chore(assets): Recompile assets
5dcd78f 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux force-pushed the fix/pass-hide-download-in-update-request branch from add64e9 to 5dcd78f Compare March 18, 2025 15:02
@susnux
Copy link
Contributor

susnux commented Mar 19, 2025

ci looks good so just reviews needed.

@yemkareems yemkareems assigned yemkareems and unassigned yemkareems Mar 19, 2025
@yemkareems yemkareems merged commit f85154f into master Mar 19, 2025
121 checks passed
@yemkareems yemkareems deleted the fix/pass-hide-download-in-update-request branch March 19, 2025 13:08
This was referenced Mar 19, 2025
Merged
Merged
Merged
@gdnmhr
Copy link

gdnmhr commented Mar 20, 2025

Does that also fix (partially) #51245, i.e. is the "allow download" attribute now checkable & retained for remote reshares?

@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@nfebe nfebe nfebe approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@yemkareems yemkareems

Labels

3. to review Waiting for reviews bug feature: sharing

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: Hide download in share creation is not retained after it is checked while share is created

7 participants

@yemkareems @susnux @gdnmhr @nfebe @skjnldsv @nextcloud-command