Skip to content

fix(s3): Trim the bucket name to make it DNS compatible #51192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(s3): Trim the bucket name to make it DNS compatible #51192

wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Mar 3, 2025 •
edited by susnux
Loading

Summary

TODO

  • ...

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Mar 3, 2025
susnux
susnux reviewed Mar 3, 2025
View reviewed changes
@solracsf solracsf closed this May 30, 2025
@susnux susnux reopened this May 31, 2025
@solracsf @susnux
fix(s3): Trim the bucket name to make it DNS compatible
3b4061c 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@susnux susnux force-pushed the trimBucketDnsName branch from ecf3abd to 3b4061c Compare May 31, 2025 15:24
susnux
susnux approved these changes May 31, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work fine

@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 31, 2025
@susnux susnux marked this pull request as ready for review May 31, 2025 15:25
@susnux susnux requested a review from a team as a code owner May 31, 2025 15:25
@susnux susnux requested review from Altahrim, nfebe and sorbaugh and removed request for a team May 31, 2025 15:25
This was referenced Aug 22, 2025
Merged
Merged
Merged
This was referenced Sep 2, 2025
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 10, 2025
Merged
@solracsf solracsf closed this Sep 16, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@solracsf solracsf

Labels

3. to review Waiting for reviews bug feature: external storage

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

[Bug]: Exception: The bucket will not be created because the name is not dns compatible ( backblaze S3 bucket)

3 participants

@solracsf @susnux @skjnldsv