fix(dav): Create SAB at installation #51144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
SebastianKrupinski and
hamza221
as code owners
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
SebastianKrupinski
approved these changes
Feb 28, 2025
kesselb
reviewed
Mar 1, 2025
apps/dav/tests/unit/Migration/CreateSystemAddressBookStepTest.php
Outdated
Show resolved
Hide resolved
ChristophWurst
force-pushed
the
fix/dav/create-sab-install
branch
from
0dc9390 to
2528e70
Compare
ChristophWurst
added
4. to release
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
kesselb
force-pushed
the
fix/dav/create-sab-install
branch
from
2528e70 to
ec664b0
Compare
kesselb
requested review from
icewind1991,
provokateurin and
yemkareems
and removed request for
a team
provokateurin
approved these changes
Mar 7, 2025
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
This was referenced Mar 7, 2025
This was referenced Mar 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The SAB is created on demand. Weirdly enough this only happens for the second user of an instance, and in high concurrent setups there can be a race for the creation of the AB.
This moves the creation to an install repair step that is run once at installation time.
This change was tested with nextcloud/mail#10707. Recently Mail integration tests failed when the SAB didn't exist and tests created it while being in a transaction.
TODO
Checklist