Fix disabled user list for SAML group subadmin #51108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
changed the title
come-nc
requested review from
a team,
blizzz,
skjnldsv,
sorbaugh and
yemkareems
and removed request for
a team
blizzz
reviewed
Feb 27, 2025
blizzz
reviewed
Feb 27, 2025
come-nc
force-pushed
the
fix/fix-disabled-user-list-for-saml-subadmin
branch
from
0de1e1f to
52872ae
Compare
blizzz
approved these changes
Mar 4, 2025
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
If too many users return -1 as for LDAP so that link is shown Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-disabled-user-list-for-saml-subadmin
branch
from
c157af2 to
c59400d
Compare
This was referenced Mar 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a subadmin of a group opens user list, if the group is not backed in database or LDAP (SAML for instance), disabled user list is not accessible.
This fixes it by counting enabled and disabled users independently of the backend for subadmin, and limits the user count to 999 for performance reasons.
Checklist