-
-
Couldn't load subscription status.
- Fork 4.6k
fix(singularandpluralfiles):implemented ternary operator to handle si… #51031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(singularandpluralfiles):implemented ternary operator to handle si… #51031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request!
But this will not work as conditions do not work inside t and n (will break the string extraction).
Also for plural forms n should be used.
|
See comment on the issue :) |
87252cb to
93f5c4c
Compare
|
We need this as you can never assume anything about other languages and how they do plural. |
|
@caitjordan17 thank you very much for your contribution :) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good 👍
|
/compile rebase / |
Co-authored-by: Caitlin Jordan <jordan.cait17@gmail.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
93f5c4c to
50b77ee
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/51031/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ee013b47 50b77ee4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51031/stable31Error: fatal: ambiguous argument 'stable31': unknown revision or path not in the working tree. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable31 |
fix(singularandpluralfiles): implemented ternary operator to handle singular and plural cases. Signed-off-by: Caitlin J Hobbs jordan.cait17@gmail.com
Summary
Used ternary operator to handle singular and plural cases depending on the value of {count} in showError and showSuccess
TODO
Checklist