Skip to content

Conversation

@caitjordan17
Copy link
Contributor

fix(singularandpluralfiles): implemented ternary operator to handle singular and plural cases. Signed-off-by: Caitlin J Hobbs jordan.cait17@gmail.com

Summary

Used ternary operator to handle singular and plural cases depending on the value of {count} in showError and showSuccess

TODO

  • ...

Checklist

@susnux susnux added bug 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters labels Feb 25, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request!
But this will not work as conditions do not work inside t and n (will break the string extraction).
Also for plural forms n should be used.

@skjnldsv
Copy link
Member

See comment on the issue :)

@skjnldsv skjnldsv closed this Feb 27, 2025
@susnux susnux reopened this Feb 28, 2025
@susnux susnux force-pushed the chobbs-singular-and-plural branch from 87252cb to 93f5c4c Compare February 28, 2025 18:55
@susnux
Copy link
Contributor

susnux commented Feb 28, 2025

We need this as you can never assume anything about other languages and how they do plural.
Everything that refers to N elements must go through n(...) for proper translation.

@susnux susnux requested review from a team, nfebe and szaimen and removed request for a team February 28, 2025 18:57
@susnux
Copy link
Contributor

susnux commented Feb 28, 2025

@caitjordan17 thank you very much for your contribution :)

@szaimen szaimen removed their request for review February 28, 2025 19:56
@susnux susnux added this to the Nextcloud 32 milestone Mar 2, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good 👍

@skjnldsv
Copy link
Member

/compile rebase /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 12, 2025
caitjordan17 and others added 2 commits March 12, 2025 09:02
Co-authored-by: Caitlin Jordan <jordan.cait17@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the chobbs-singular-and-plural branch from 93f5c4c to 50b77ee Compare March 12, 2025 08:24
@skjnldsv skjnldsv requested a review from a team as a code owner March 12, 2025 08:24
@skjnldsv skjnldsv requested review from szaimen and removed request for a team March 12, 2025 08:24
@skjnldsv skjnldsv requested a review from sorbaugh March 12, 2025 08:24
@skjnldsv skjnldsv merged commit 460765d into nextcloud:master Mar 12, 2025
107 of 111 checks passed
@welcome
Copy link

welcome bot commented Mar 12, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv
Copy link
Member

/backport to stable31

@backportbot
Copy link

backportbot bot commented Mar 12, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/51031/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ee013b47 50b77ee4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51031/stable31

Error: fatal: ambiguous argument 'stable31': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: language/translations (l10n/i18n) Localization and translation matters feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[l10n]: Singular and plural for number of files

3 participants