fix: Use case insensitive check when validating login name #50989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
reviewed
Feb 24, 2025
enjeck
force-pushed
the
case-insensitive-login
branch
3 times, most recently
from
f9b7d47 to
126563c
Compare
susnux
approved these changes
Feb 25, 2025
juliusknorr
approved these changes
Feb 26, 2025
blizzz
previously requested changes
Feb 26, 2025
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
from strcasecmp docs:
Binary safe case-insensitive string comparison. The comparison is not locale aware; only ASCII letters are compared in a case-insensitive way.
Contrary to the user id, there is no restriction on characters on login names.
Better to switch to mb_strtolower?
Contributor
Oh yes I missed that (maybe because there is no |
susnux
reviewed
Feb 26, 2025
blizzz
approved these changes
Mar 4, 2025
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
case-insensitive-login
branch
from
961d47b to
32e46a8
Compare
enjeck
requested review from
come-nc,
icewind1991 and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use case insensitive check when validating login name
TODO
Checklist