[stable30] fix: don't use cached root info from shared cache if the watcher has detected an update #50761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
…detected an update Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
backport/50324/stable30
branch
from
23f2804 to
3bfcd83
Compare
|
removed the interface changes |
icewind1991
approved these changes
Feb 11, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!(str_starts_with($storageId, 'home::') || str_starts_with($storageId, 'object::user'))) { | ||
| $cache = $this->getCache(); | ||
| $this->watcher = parent::getWatcher($path, $storage); | ||
| if ($cache instanceof Cache && $this->watcher instanceof Watcher) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType Note
come-nc
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #50324
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.