Skip to content

Conversation

@grnd-alt
Copy link
Member

@grnd-alt grnd-alt commented Feb 5, 2025

When using occ file:transfer-ownership, we had issues reported that not all files where transferred when using s3 buckets as file storage.

This PR improves the logging of the occ command to inform users when not all files are transferred.

@grnd-alt grnd-alt force-pushed the enh/improve-transfer-ownership-logging branch from 77d0617 to 3b85ca0 Compare February 5, 2025 12:13
@grnd-alt grnd-alt force-pushed the enh/improve-transfer-ownership-logging branch from 3b85ca0 to c00b9bd Compare February 5, 2025 13:05
@juliusknorr juliusknorr added enhancement 3. to review Waiting for reviews labels Feb 6, 2025
@juliusknorr juliusknorr added this to the Nextcloud 32 milestone Feb 6, 2025
@juliusknorr
Copy link
Member

@grnd-alt Please assign labels on new prs and provide a meaninful description, especially for reviewers that have not been involved before this will speed up review as it is easier to understand the context

@juliusknorr
Copy link
Member

Also conventional commit message should be feat not fix I'd say

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current wording is not clear enough I think.

@grnd-alt grnd-alt force-pushed the enh/improve-transfer-ownership-logging branch 3 times, most recently from f8b7509 to a1fd916 Compare February 11, 2025 07:59
@come-nc
Copy link
Contributor

come-nc commented Feb 13, 2025

I’m afraid of the performance impact of this.
For source size it may have it in cache, but for the destination user it will force a full scan, no?
Also, the source size may not be perfectly up to date in the cache and this will result in a false-positive?

@juliusknorr
Copy link
Member

For source size it may have it in cache, but for the destination user it will force a full scan, no?

I don't see how it should trigger a scan. If the transfer is doing a copy then the files size will be set on write, if the transfer moves it will just keep the filecache entries size information. I also do not see or remember a code path that would trigger this on access of the size, but may miss something.

Also, the source size may not be perfectly up to date in the cache and this will result in a false-positive?

That may be. We could do more detailed checks, but that would also have performance impact. As far as I see this PR would be mainly an indicator that something might be off. Maybe something to clarify with the wording of the message.

@grnd-alt grnd-alt force-pushed the enh/improve-transfer-ownership-logging branch from a1fd916 to 09c33c7 Compare March 5, 2025 09:02
@grnd-alt grnd-alt requested a review from a team as a code owner March 5, 2025 09:02
@grnd-alt grnd-alt requested review from Altahrim and yemkareems and removed request for a team March 5, 2025 09:02
@grnd-alt grnd-alt force-pushed the enh/improve-transfer-ownership-logging branch from 09c33c7 to a9064e2 Compare March 5, 2025 09:10
Signed-off-by: grnd-alt <github@belakkaf.net>
@grnd-alt grnd-alt force-pushed the enh/improve-transfer-ownership-logging branch from a9064e2 to 3e1fd05 Compare March 6, 2025 08:47
@grnd-alt grnd-alt requested a review from juliusknorr March 10, 2025 11:42
@grnd-alt
Copy link
Member Author

/backport to stable31

@grnd-alt
Copy link
Member Author

/backport to stable30

@grnd-alt
Copy link
Member Author

/backport to stable29

@grnd-alt
Copy link
Member Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants