fix: Check that user actually can validate password for js

[zorn-v]

Add missing check for js template

• Fix Disable password confirmation not working zorn-v/nextcloud-social-login#494
• Fix [Bug]: External storage will prompt for password but always tell you it's the wrong password #51919

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[skjnldsv]

Can't believe I'm only finding this pr now.
After all the discussion we had on #51919 🥲🥲🥲
Thanks @zorn-v

[artonge]

Indeed, many thanks @zorn-v !

[skjnldsv]

/backport to stable31

[skjnldsv]

/backport to stable30

[skjnldsv]

/backport to stable29

[ghnfox509]

I installed nextcloud 31.0.4 yesterday and experienced this issue, then upgraded to 31.0.5 a few minutes ago which says has this fix but the issue remains for me. I have LDAP auth enabled but am using the local nextcloud admin account to make changes. In other spots where it asks me to verify my password it works fine but on external storage it does not. Is there another way to add external storage, perhaps modifying the DB directly or something? Would really like to get things going, once my 4 external storage points are added and mapped to allow the right groups to access them (migrating from ownCloud which I have used for this purpose for about the past 12 years), I don't really need to make changes to external storage again.

UPDATE: I managed to work around this by exporting the DB rows from my owncloud external config setup to nextcloud that seemed to work fine.

[derthomsn86]

I have to +1 the comment of @ghnfox509 - im waiting for the fix since multiple versions. I installed 31.0.5. but im still not able to connect to an external ftp server due to this error.

[derthomsn86]

In addition - it seems, that the bug disappears for external FTPs after i disabled(!) previews for the given Entry.
Maybe that helps someone.

[whygit2000]

31.0.5 still have problem with smb as external storage.[Bug]: External storage will prompt for password but always tell you it's the wrong password . Still haven't fixed-

nextcloud env：
No LDAP
PHP version：php 8.2.21
mysql version： 10.11.6
OS: synology DSM 7.2 (Debian base distro)

I was able to add SMB/CIFS external storage with old nextcloud server version before. But the fresh install with newest nextcloud version just can't.

I am trying to add 127.0.0.1's local SMB share folder like : "download" for nextcloud and it will work in the old version nextcloud, for example like 28.x before. And I even I try to change IP address to like 192.168.X.X for the localhost's private IP and it just can't. But remember that it can work on older nextcloud version.

Finnally , I can add local folder as "external storage" instead of going though SMB protocal for testing purpose, for example：sudo setfacl -Rm u:http:rwX /path/to/download， The prompt to enter a password appears， but I can pass the password authentication with newest nextcloud version 31.0.5.

It seems the bug related to specific protocal like SMB, WebDev etc., but no problem with just local folder.

[skjnldsv]

Please everyone, describe your setup.
What Webserver? what php version? are you all using LDAP? Is the account that experience this also an ldap account?

[skjnldsv]

@whygit2000 thanks, what's your webserver? Apache?
Can you also list your modules? If you have mod_env, please test without it

[skjnldsv]

Let's continue in #53472