Add integration tests for renaming a share by a user with stale shares #50229
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
approved these changes
Jan 17, 2025
|
/backport to stable31 |
… shares Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
AndyScherzinger
force-pushed
the
add-integration-tests-for-renaming-a-share-by-a-user-with-stale-shares
branch
from
b8860a9 to
53204f4
Compare
danxuliu
added
help wanted
2. developing
|
/backport to stable30 |
|
The commit that fixed this issue was reverted in #50389 Therefore, although the integration tests should be valid, they will fail until the issue is fixed again. For a detailed description about the issue please check #50228 Unfortunately I do not know how to fix the issue myself (besides catching the exception, but I assume there is a cleaner and more generic fix like the one that had to be reverted), so @sorbaugh I would need someone else to take over :-) Thanks! |
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #49073 renaming a received share failed with an internal server error if the receiver of the share had another share, and the source file for that share was deleted. This pull request adds integration tests to check that scenario.
The integration tests as well as the specific commit that fixes the issue were backported to the stable branches (<= 30) in #50228