fix(caldav): rename default calendar to keep it in the trashbin instead of purging it #50034
+21
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
ChristophWurst,
miaulalala and
SebastianKrupinski
|
/backport to stable30 |
|
/backport to stable29 |
tcitworld
force-pushed
the
rename-deleted-default-calendar-in-trashbin
branch
2 times, most recently
from
5c28c3a to
74deaf1
Compare
…ad of purging it When doing a PROPFIND on default-calendar-url, if the current default calendar (fallbacking on personal uri) is in the trashbin, it's being purged so that it's recreated. This leads to loss of data. We can simply rename the calendar URI and add a unique suffix so that it doesn't conflict with the new calendar being created. Shares are fine because they reference the resourceid and not the calendar URI. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
rename-deleted-default-calendar-in-trashbin
branch
from
74deaf1 to
ef0e221
Compare
ChristophWurst
approved these changes
Jan 8, 2025
Merged
st3iny
approved these changes
Jan 11, 2025
st3iny
added
bug
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When doing a PROPFIND on default-calendar-url, if the current default calendar (fallbacking on personal uri) is in the trashbin, it's being purged so that it's recreated.
This leads to loss of data.
We can simply rename the calendar URI and add a suffix so that it doesn't conflict with the new calendar being created.
Shares are fine because they reference the
resourceidand not the calendar URI.TODO
moveCalendarnot inSabre\CalDAV\Backend\BackendInterfaceChecklist