fix: add owner fallback

[miaulalala]

Signed-off-by: Anna Larch anna@nextcloud.com

• Resolves: #

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[miaulalala]

/backport to stable28

[solracsf]

DRY 🙈

/**
 * Retrieve the path relative to the current user root folder.
 * If no user is connected, try to use the node's owner.
 */
private function getPathForNode(Node $node): ?string {
	$user = $this->userSession->getUser()?->getUID();
	if ($user !== null) {
		return $this->getRelativePathForUser($user, $node);
	}

	$owner = $node->getOwner()?->getUid();
	if ($owner !== null) {
		return $this->getRelativePathForUser($owner, $node);
	}

	// Attempt to extract the owner from the path
	$parts = explode('/', $node->getPath(), 4);
	$owner = (count($parts) === 4) ? $parts[1] : null;
	if ($owner !== null) {
		return $this->getRelativePathForUser($owner, $node);
	}

	return null;
}

/**
 * Get the relative path for a given user and node.
 */
private function getRelativePathForUser(string $user, Node $node): ?string {
	return $this->rootFolder
		->getUserFolder($user)
		->getRelativePath($node->getPath()) ?: null;
}

[artonge]

Not sure what the difference is with the original

[SystemKeeper]

Not sure what the difference is with the original

In the original version we only try to extract the owner from the path, when we are unable to get the owner from the node.

Now we try to get the owner from the path as a fallback in all cases.

[skjnldsv]

29 is now EOL